diff options
| author | Felix Fietkau <nbd@openwrt.org> | 2014-04-12 14:28:34 +0000 |
|---|---|---|
| committer | Felix Fietkau <nbd@openwrt.org> | 2014-04-12 14:28:34 +0000 |
| commit | 0d7e8ba3a9f59b4f2e49b2f7c9d7b0cf8078de31 (patch) | |
| tree | f60a23b87c39205bc049e5ae16f49f10e8a1180d | |
| parent | f79b6139344265d9a55e752bc640e16feee6d02f (diff) | |
| download | mtk-20170518-0d7e8ba3a9f59b4f2e49b2f7c9d7b0cf8078de31.zip mtk-20170518-0d7e8ba3a9f59b4f2e49b2f7c9d7b0cf8078de31.tar.gz mtk-20170518-0d7e8ba3a9f59b4f2e49b2f7c9d7b0cf8078de31.tar.bz2 | |
hostapd: fix "bad number" error due to missing wps_pbc_in_m1 option (since r39995)
r39995 introduced a new parameter wps_pbc_in_m1 to wifi wps config, but
apparently did not provide a default value 0.
When that option's non-existing value is later evaluated in
/lib/netifd/hostapd.sh, it causes the "bad number" error to be logged in
syslog if user has not set the wps_pbc_in_m1 option. The error materialises
only if user has enabled wps.
Sat Apr 12 13:25:01 2014 daemon.notice netifd: radio1 (1254): sh: bad number
Sat Apr 12 13:25:01 2014 daemon.notice netifd: radio0 (1253): sh: bad number
Discussion in bug 15508: https://dev.openwrt.org/ticket/15508#comment:3
Error is caused by line 282:
https://dev.openwrt.org/browser/trunk/package/network/services/hostapd/files/netifd.sh#L282
My patch sets the parameter's default value to 0, which does nothing. The
default might also be set a bit later in the function, but this felt like the
most clear place to do that.
Signed-off-by hnyman <hannu.nyman@iki.fi>
SVN-Revision: 40469
| -rw-r--r-- | package/network/services/hostapd/files/netifd.sh | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/package/network/services/hostapd/files/netifd.sh b/package/network/services/hostapd/files/netifd.sh index e6921ef..1232669 100644 --- a/package/network/services/hostapd/files/netifd.sh +++ b/package/network/services/hostapd/files/netifd.sh @@ -254,6 +254,7 @@ hostapd_set_bss_options() { set_default wps_pushbutton 0 set_default wps_label 0 + set_default wps_pbc_in_m1 0 config_methods= [ "$wps_pushbutton" -gt 0 ] && append config_methods push_button |