summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonas Gorski <jogo@openwrt.org>2013-02-10 12:31:36 +0000
committerJonas Gorski <jogo@openwrt.org>2013-02-10 12:31:36 +0000
commiteedc3554fe4b8161c8327efb0d40d095cf55874c (patch)
treeba617deb12a2c9a9990e431090ca317b50c2c7f4
parent200359a52055687d1edbf71e90d63aab141fd2f5 (diff)
downloadmtk-20170518-eedc3554fe4b8161c8327efb0d40d095cf55874c.zip
mtk-20170518-eedc3554fe4b8161c8327efb0d40d095cf55874c.tar.gz
mtk-20170518-eedc3554fe4b8161c8327efb0d40d095cf55874c.tar.bz2
generic: b53: fix reverted error check in probe
b53_switch_detect returns value returned by b53_read8, which is 0 for success. So fail (and return error) only if b53_switch_detect returned something else than 0. This fixes supported and advertising being zeros for MDIO access. Cc: Jonas Gorski <jogo@openwrt.org> Signed-off-by: Rafał Miłecki <zajec5@gmail.com> SVN-Revision: 35534
-rw-r--r--target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c b/target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c
index 9283af60..1ba0591 100644
--- a/target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c
+++ b/target/linux/generic/files/drivers/net/phy/b53/b53_mdio.c
@@ -267,7 +267,7 @@ static int b53_phy_probe(struct phy_device *phydev)
mutex_init(&dev.reg_mutex);
ret = b53_switch_detect(&dev);
- if (!ret)
+ if (ret)
return ret;
if (is5325(&dev) || is5365(&dev))